Skip to content

Conversation

@MasterIfeanyi
Copy link

🐛 Fix: Add UI to filter memos by Links, Code, and To-do

Problem

Fixes #5289

Users were unable to filter memos by Links, Code blocks, or To-do lists. While the filtering logic existed in the backend and filter display components worked correctly, there was no UI element to actually select these filters.

What Changed

Added a new MemoFilterMenu component that provides a dropdown interface to toggle property-based filters:

  • 🔗 Filter by Links (property.hasLink)
  • ☑️ Filter by To-do lists (property.hasTaskList)
  • 💻 Filter by Code blocks (property.hasCode)

Technical Details

  • New Component: MemoFilterMenu.tsx - Filter selection dropdown with toggle functionality
  • Updated Component: SearchBar.tsx - Added filter menu button next to existing settings button
  • Uses existing memoFilterStore for state management
  • Filters are displayed as removable chips via existing MemoFilters.tsx component
  • Active filters are highlighted and show checkmarks

How It Works

  1. User clicks the filter icon (🔍) next to the search bar
  2. Dropdown shows available property filters
  3. Click to toggle filters on/off
  4. Active filters appear as removable chips above the memo list
  5. Memos are filtered in real-time using existing useMemoFilters hook

Testing

  • Filter menu appears next to settings icon in search bar
  • Clicking filter options adds/removes filters correctly
  • Active filters show with checkmark and highlight
  • Filter button highlights when filters are active
  • Memos filter correctly by selected properties
  • Filters can be removed via the dropdown or filter chips

Screenshots

New Implementation showing the new MemoFilterMenu component
Screenshot 2025-12-16 232522

Before: No way to select property filters
After: Filter menu with Links, To-do, and Code options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't Filter by Links, Task List or Code

1 participant