feat(auth): add support for Supabase Auth sb identifier #1959
+119
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add client-side support for the
sbidentifier that Supabase Auth server adds to OAuth redirect URLs (supabase/auth#2299).Problem
auth-jsintercepts all URL fragments containingaccess_token, including those from non-Supabase OAuth providers (e.g., Facebook Login). This causes unintended authentication issues when apps use multiple OAuth providers.Solution
_isImplicitGrantCallback()to check for thesbparameter firstaccess_token/error_description) for backwards compatibility with older Auth server versionsExample
Related
Blocked by:
TODO as breaking change
On v3, as breaking change, remove the legacy fallback