feat: implemented max-nth-double-factorial missing constant #9260
+502
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames status: passed
- task: lint_editorconfig status: passed
- task: lint_markdown status: passed
- task: lint_package_json status: passed
- task: lint_repl_help status: passed
- task: lint_javascript_src status: passed
- task: lint_javascript_cli status: na
- task: lint_javascript_examples status: passed
- task: lint_javascript_tests status: passed
- task: lint_javascript_benchmarks status: na
- task: lint_python status: na
- task: lint_r status: na
- task: lint_c_src status: na
- task: lint_c_examples status: na
- task: lint_c_benchmarks status: na
- task: lint_c_tests_fixtures status: na
- task: lint_shell status: na
- task: lint_typescript_declarations status: passed
- task: lint_typescript_tests status: passed
- task: lint_license_headers status: passed
Resolves #9061.
Description
This pull request:
@stdlib/constants/float16/max-nth-double-factorialconstant12, since12!! = 46080fits within float16 max (65504), while13!! = 135135overflowsRelated Issues
This pull request has the following related issues:
Questions
No.
Other
Implementation Details:
1212!! = 12 × 10 × 8 × 6 × 4 × 2 = 46,080(within float16 range)13!! = 135,135(exceeds float16 max of 65,504)max-nth-double-factorialconstantsChecklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was partially written with the help of Claude Code for initial implementation, following the existing patterns from float32/float64 max-nth-double-factorial constants and merged float16 PRs. The constant value was calculated programmatically, and the entire implementation was thoroughly reviewed and verified by me to ensure correctness and adherence to project standards.
@stdlib-js/reviewers