Skip to content

Conversation

@Ketan-Ag
Copy link
Contributor

Resolves #9149.

Description

What is the purpose of this pull request?

This pull request:

  • This pull request fixes a broken Markdown link in the DLASET README. The previous LAPACK documentation URL returned a 404 because the referenced Netlib Doxygen page no longer exists. The link has been updated to a current working LAPACK DLASET documentation page

Related Issues

Does this pull request have any related issues?

This pull request does not have any issues beyond #9149.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I consulted ChatGPT to help locate the current LAPACK documentation and to assist in writing the pull request summary, but the actual change was authored manually.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. and removed Good First PR A pull request resolving a Good First Issue. labels Dec 19, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 19, 2025

Coverage Report

Package Statements Branches Functions Lines
lapack/base/dlaset $\color{green}592/592$
$\color{green}+0.00%$
$\color{green}37/37$
$\color{green}+0.00%$
$\color{green}7/7$
$\color{green}+0.00%$
$\color{green}592/592$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Philipp Burckhardt <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first PR! Will land it shortly.

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Dec 19, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 19, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 19, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 19, 2025

PR Commit Message

docs: fix broken Markdown link

PR-URL: https://github.com/stdlib-js/stdlib/pull/9249
Closes: https://github.com/stdlib-js/stdlib/issues/9149

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Ketan-Ag <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit b0962b9 into stdlib-js:develop Dec 19, 2025
46 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix broken Markdown link: https://www.netlib.org/lapack/explore-html-3.6.1/d7/d43/group__aux_o_t_h_e_rauxiliary_ga89e332374c7cd87e5db54bfe21550bc3.html

3 participants