Add a link to browse crate source on docs.rs #12550
Open
+203
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't show the link if there aren't any docs.rs builds as clicking on the link won't work then, but do still show the source link even if a non-docs.rs documentation link has been specified to enable review of the source exactly as crates.io serves it.
syphar
reviewed
Dec 19, 2025
|
|
||
| get docsRsSourceLink() { | ||
| if (this.hasDocsRsLink) { | ||
| return `https://docs.rs/crate/${this.crateName}/${this.num}/source/`; |
Member
There was a problem hiding this comment.
I think we can show the link more often.
from what I see, hasDocsRsLink is based on our status-json result (doc_status in there).
But we also have & host the source when:
- it's a binary crate, or
- the if the doc-build failed
- when the build is in progress
The only edge cases here would be when the build is queued, or we didn't get the update from the registry yet.
I think you're good in just checking if you have a result from our status endpoint, no matter what you see in doc_status
Member
There was a problem hiding this comment.
there is also rust-lang/docs.rs#2762 where we would try to serve a nice page even for just queued releases
Turbo87
added
the
C-enhancement ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't show the link if there aren't any docs.rs builds as clicking on the link won't work then, but do still show the source link even if a non-docs.rs documentation link has been specified to enable review of the source exactly as crates.io serves it.