-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-142972: Document arbitrary ordering in Path.glob
#143025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say 'unordered' or 'no ordering guarantees'. Please also add the note to rglob().
A
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Thanks. Would you also like me to correct the glob module documention to use the same wording? Lines 28 to 31 in ec269e1
|
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @AA-Turner: please review the changes made to this pull request. |
|
Oh, fine: in that case just reuse the exact wording (ie drop 'akin' etc) A |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @AA-Turner: please review the changes made to this pull request. |
AA-Turner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Unless @barneygale has any comments, will merge in a few days.
A
pathlib.path.rglobno longer returns sorted files starting at3.12#142972📚 Documentation preview 📚: https://cpython-previews--143025.org.readthedocs.build/