gh-141778: add missing validation in ast.literal_eval() for non-string input #142969
+22
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-string input This also changes parsing of the private `__text_signature__` attribute by inspect.signature(). Now we accept here only types, valid for ast.Constant().
skirpichev
requested review from
Eclips4,
JelleZijlstra,
isidentical and
tomasr8
as code owners
| _type_Ellipsis = type(...) | ||
|
|
||
|
|
||
| def _convert_literal(node, omit_validation=False): |
Member
There was a problem hiding this comment.
Why do we need this change? It may make life harder for some users.
Contributor
Author
There was a problem hiding this comment.
Could you be more precise, any example?
We need this, because literal_eval() accepts invalid AST for non-string input. Per documentation:
The string or node provided may only consist of the following Python literal structures: strings, bytes, numbers, tuples, lists, dicts, sets, booleans, None and Ellipsis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes parsing of the private
__text_signature__attribute byinspect.signature(). Now we accept here only types, valid forast.Constant().