Skip to content

Conversation

@gcamargo2
Copy link

…thod

PR Description

Please describe the changes proposed in the pull request:

This PR resolves #(put issue number here, and remove parentheses).

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@gcamargo2
Copy link
Author

this was breaking the package once I upgrade it.

@ericmjl
Copy link
Member

ericmjl commented Dec 6, 2025

@gcamargo2 thanks for the PR. I notice it's duplicate with #1535. Not an issue here, I'm going to merge #1535 but acknowledge that both of you found the issue and made a PR. Thank you!

@gcamargo2
Copy link
Author

thanks @ericmjl !

@ericmjl
Copy link
Member

ericmjl commented Dec 15, 2025

@gcamargo2 you've been tagged/acknowledged in a separate infra PR that I'm working on, #1540! Going to close out this PR.

@ericmjl ericmjl closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants