Nialexsan/extra check erc4626 #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kay-Zee
approved these changes
Dec 12, 2025
Comment on lines
529
to
545
| access(self) fun _toCadenceOut( | ||
| _ amt: UInt256, | ||
| erc20Address: EVM.EVMAddress | ||
| ): UFix64 { | ||
| // Bridge utils already floors when going UInt256 -> UFix64 | ||
| return FlowEVMBridgeUtils.convertERC20AmountToCadenceAmount( | ||
| amt, | ||
| erc20Address: erc20Address | ||
| ) | ||
| } | ||
|
|
||
| /// IN amounts: round up to the next UFix64 such that the ERC20 conversion | ||
| /// (via ufix64ToUInt256) is >= the original UInt256 amount. | ||
| access(self) fun _toCadenceIn( | ||
| _ amt: UInt256, | ||
| erc20Address: EVM.EVMAddress | ||
| ): UFix64 { |
Collaborator
There was a problem hiding this comment.
IMO we should add test cases & ensure cases across extremes are covered since rounding is a common failure point. Will likely require exposing _toCadenceIn() these methods as access(all)
Contributor
Author
There was a problem hiding this comment.
added tests and moved the methods to the contract level for convenience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.