896 - feat: update to register v4 #1045
Open
+71
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR SummaryUpdated the account registration flow to use the v4 API endpoint. Added a new Changes
autogenerated by presubmit.ai |
lealobanov
temporarily deployed
to
development
GitHub Actions
Inactive
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (1)
- packages/services/src/ProfileService.ts (3 hunks)
Actionable Comments (0)
Skipped Comments (2)
-
packages/services/src/ProfileService.ts [454-459]
possible bug: "Non-null assertion on potentially undefined value."
-
packages/services/src/ProfileService.ts [477-479]
possible issue: "Response structure handling may be inconsistent."
lealobanov
temporarily deployed
to
development
GitHub Actions
Inactive
Closes #896
lealobanov
temporarily deployed
to
development
GitHub Actions
Inactive
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (4)
- apps/react-native/src/bridge/NativeFRWBridge.ts (1 hunk)
- apps/react-native/src/bridge/PlatformImpl.ts (1 hunk)
- packages/context/src/interfaces/PlatformSpec.ts (1 hunk)
- packages/screens/src/onboarding/ConfirmRecoveryPhraseScreen.query.tsx (2 hunks)
Actionable Comments (0)
Skipped Comments (2)
-
packages/screens/src/onboarding/ConfirmRecoveryPhraseScreen.query.tsx [194-207]
possible issue: "Uninitialized variable could lead to undefined usage."
-
packages/screens/src/onboarding/ConfirmRecoveryPhraseScreen.query.tsx [200-200]
security: "Ensure signature value is not logged."
lealobanov
temporarily deployed
to
development
GitHub Actions
Inactive
lmcmz
requested changes
Dec 12, 2025
| public_key: accountKey.publicKey, | ||
| sign_algo: accountKey.signAlgo, | ||
| hash_algo: accountKey.hashAlgo, | ||
| }, |
lealobanov
temporarily deployed
to
development
GitHub Actions
Inactive
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (5)
- apps/react-native/src/bridge/NativeFRWBridge.ts (2 hunks)
- apps/react-native/src/bridge/PlatformImpl.ts (1 hunk)
- packages/context/src/interfaces/PlatformSpec.ts (1 hunk)
- packages/screens/src/onboarding/ConfirmRecoveryPhraseScreen.query.tsx (1 hunk)
- packages/services/src/ProfileService.ts (2 hunks)
Actionable Comments (0)
Skipped Comments (2)
-
packages/screens/src/onboarding/ConfirmRecoveryPhraseScreen.query.tsx [216-227]
possible issue: "Missing deviceInfo parameter in registerV4 call."
-
packages/screens/src/onboarding/ConfirmRecoveryPhraseScreen.query.tsx [198-200]
enhancement: "Late capability check may lead to poor user experience."
lealobanov
temporarily deployed
to
development
GitHub Actions
Inactive
lealobanov
temporarily deployed
to
development
GitHub Actions
Inactive
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 614706c: Merge branch 'dev' into 896-register-v4
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)
lealobanov
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #896
🔗 Related Issues
Linked automatically from the branch name. If incorrect, edit:
Self-Checklist
📝 Description
📸 Screenshots/Videos