Skip to content

Conversation

@lmcmz
Copy link
Collaborator

@lmcmz lmcmz commented Dec 10, 2025

🔗 Related Issues

Linked automatically from the branch name. If incorrect, edit:

📝 Description

📸 Screenshots/Videos

@lmcmz lmcmz requested review from a team as code owners December 10, 2025 05:10
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

PR Summary

Released mobile version 3.0.6 with several bug fixes and improvements. Fixed the native tag issue in the cadence header by using RNPlatform.OS instead of a hardcoded string. Addressed the contract address empty issue by swapping the priority order for selecting evmAddress and contractAddress, and added a fallback mechanism to resolve missing EVM token contract addresses from the tokenStore cache. Updated the EVM default gas limit from 30,000,000 to 16,777,216. Added validation for non-FLOW EVM token transfers to require a valid contract address. Updated Android and iOS submodules to their latest commits.

Changes

File Summary
apps/react-native/android Updated Android submodule to commit d4548947abdaadf9f7d83aa6257caae936ea06b3 (r3.0.5 - Blocto restore fix).
apps/react-native/ios Updated iOS submodule to commit d8bfa79626c39f38db6b4e791b59492c22df0c2d.
apps/react-native/src/bridge/PlatformImpl.ts Changed the platform variable from a hardcoded 'react-native' string to use RNPlatform.OS for accurate platform detection in the cadence header.
packages/stores/src/sendStore.ts Swapped priority order to prefer contractAddress over evmAddress. Added a fallback mechanism to resolve missing EVM token contract addresses by looking up the token in tokenStore cache using identifier, contractAddress, or symbol matching.
packages/workflow/src/send/utils.ts Changed EVM_DEFAULT gas limit from 30_000_000 to 16_777_216.
packages/workflow/src/send/validation.ts Added validation for non-FLOW EVM token transfers to require a valid contract address. Removed commented-out TODO code that was previously skipping this validation.
packages/workflow/tests/send.ft.script.test.ts Added a new test case to verify that EVM token transfers throw an error when contract address is missing. Updated existing test expectations to use the new gas limit value of 16_777_216.

autogenerated by presubmit.ai

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (12)
  • 6993166: ci: update ios commit hash
  • 086e2de: fix: native tag issue in cadence header
  • c5bb363: ci: update ios commit hash
  • 3c69744: ci: update ios commit hash

Swapped the priority order for selecting evmAddress and contractAddress

  • 0647f23: fix: contract address empty issue
  • a0d01bd: ci: update mobile commit hash
  • 80d76be: feat: update android commit hash
  • da09589: fix: update EVM default gas limit

changed the evm gas limit

  • 440fbc4: chore: update android submodule to r3.0.5 - Blocto restore fix
  • 341315e: Merge pull request #672 from onflow/648-ios-release

648 ios release

  • 0f0a98c: ci: update ios commit hash

Closes #648

MOB release 3.0.4

Files Processed (7)
  • apps/react-native/android (1 hunk)
  • apps/react-native/ios (1 hunk)
  • apps/react-native/src/bridge/PlatformImpl.ts (1 hunk)
  • packages/stores/src/sendStore.ts (2 hunks)
  • packages/workflow/src/send/utils.ts (1 hunk)
  • packages/workflow/src/send/validation.ts (3 hunks)
  • packages/workflow/tests/send.ft.script.test.ts (4 hunks)
Actionable Comments (0)
Skipped Comments (2)
  • packages/stores/src/sendStore.ts [445-447]

    possible bug: "Token matching by symbol alone may cause incorrect address resolution."

  • packages/stores/src/sendStore.ts [426-428]

    possible issue: "Verify the intended priority order for contract address selection."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants