896 - Register v4 #2314
Open
896 - Register v4 #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Saves mnemonic to secure storage using Wallet.store() - Creates EOA Account in AccountManager (no Firebase UID) - Initializes WalletManager with new account - Returns success/error response
- Remove generateRecoveryPhrase() (using TypeScript implementation) - Remove createEOAAccount() stub (replaced by saveMnemonic) - Clean up unused code per code review feedback
- Resolved import conflicts in NativeFRWBridge.kt - Updated build.gradle to read GitHub credentials from local.properties
lmcmz
requested changes
Dec 12, 2025
app/src/main/java/com/flowfoundation/wallet/network/UserRegisterUtils.kt
Outdated
Show resolved
Hide resolved
...n/java/com/flowfoundation/wallet/page/restore/keystore/viewmodel/KeyStoreRestoreViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/handlers/AuthBridgeHandler.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/handlers/AuthBridgeHandler.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/handlers/AuthBridgeHandler.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/flowfoundation/wallet/reactnative/bridge/handlers/AuthBridgeHandler.kt
Outdated
Show resolved
Hide resolved
lmcmz
reviewed
Dec 12, 2025
...n/java/com/flowfoundation/wallet/page/restore/keystore/viewmodel/KeyStoreRestoreViewModel.kt
Outdated
Show resolved
Hide resolved
|
|
||
| override fun generateSeedPhrase(strength: Double?, promise: Promise) = authHandler.generateSeedPhrase(strength, promise, ::bridgeModelToWritableMap) | ||
|
|
||
| override fun getRegistrationSignature(mnemonic: String, promise: Promise) = authHandler.getRegistrationSignature(mnemonic, promise) |
Contributor
There was a problem hiding this comment.
I think you also need the EVM signature and address as well
- Resolved UserRegisterUtils.kt conflict (kept HEAD formatting) - Resolved BridgeModels.kt conflict (kept ProfileType enum name) - Resolved NativeFRWBridge.kt conflict (kept delegate handler pattern) - Accepted deletion of AccountSwitchDialog.kt (replaced by ProfileSwitchDialog)
- Adds migrateProfileTypes() to AccountManager.init() - Determines ProfileType based on signature algorithm for legacy accounts - ECDSA_P256 = Secure Enclave = HARDWARE - ECDSA_secp256k1 or other = Recovery Phrase/Keystore = FULL - Saves migrated accounts back to cache
- Set WalletManager.setEoaDisabled(true) in createWalletFromPrefix when HardwareBackedKeyException is caught (Secure Enclave accounts) - Set WalletManager.setEoaDisabled(false) for regular prefix-based keys, HD mnemonic wallets, and keystore private key imports - Remove unreliable ProfileType migration based on signature algorithm - This approach correctly handles overlay installations since the flag is set each time a wallet is initialized in WalletCreationHelper
… AuthBridgeHandler
- Rename getRegistrationSignature -> getV4RegistrationSignatures - Rename return keys: signature -> flowSignature, evmAddress -> eoaAddress - Update log messages to match new method name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #???
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)