fix(fetch): fixup generators and add error handling #8395

avivkeller · 2025-12-04T23:29:17Z

This PR:

Fixes the nasty fetch failed issue on deployments by rewriting the fetch statements to .then().catch() format
Adds a missing type file
Moves a constant to the constants file
Simplifies an object creation

vercel · 2025-12-04T23:29:22Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
nodejs-org	Ready	Preview	Dec 18, 2025 2:12pm

github-actions · 2025-12-04T23:29:30Z

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

codecov · 2025-12-04T23:30:50Z

Codecov Report

❌ Patch coverage is 76.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.65%. Comparing base (43ffe41) to head (b680586).
⚠️ Report is 27 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
apps/site/util/fetch.ts	64.70%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8395      +/-   ##
==========================================
- Coverage   76.40%   73.65%   -2.75%     
==========================================
  Files         118      108      -10     
  Lines        9928     9193     -735     
  Branches      334      312      -22     
==========================================
- Hits         7585     6771     -814     
- Misses       2341     2420      +79     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copilot

Pull request overview

This PR refactors data generator functions to use promise chain syntax (.then().catch()) instead of async/await, addressing fetch failures during deployments. The changes improve error handling by ensuring that failed fetch operations return safe default values instead of breaking the build.

Key Changes:

Refactored vulnerabilities.mjs and supportersData.mjs generators to use .then().catch() pattern with fallback values
Added supporters.ts type definitions file and exported it from the types index
Moved OPENCOLLECTIVE_MEMBERS_URL constant from inline definition to centralized next.constants.mjs

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`apps/site/types/supporters.ts`	Adds type definitions for Supporter and OpenCollectiveSupporter
`apps/site/types/index.ts`	Exports the new supporters type module
`apps/site/next.constants.mjs`	Adds OPENCOLLECTIVE_MEMBERS_URL constant for centralized configuration
`apps/site/next-data/generators/vulnerabilities.mjs`	Refactors async function to arrow function with promise chains and error handling
`apps/site/next-data/generators/supportersData.mjs`	Refactors async function to arrow function with promise chains, uses centralized constant

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/site/next-data/generators/vulnerabilities.mjs

apps/site/next-data/generators/supportersData.mjs

github-actions · 2025-12-04T23:32:52Z

📦 Build Size Comparison

Summary

Metric	Value
Old Total Size	4.34 MB
New Total Size	4.34 MB
Delta	0 B (0.00%)

Changes

➕ Added Assets (1)

Name	Size
`.next/static/chunks/4d75ead2ba2e5654.js`	204.26 KB

➖ Removed Assets (1)

Name	Size
`.next/static/chunks/1ebd0f9d6844fabb.js`	204.26 KB

avivkeller · 2025-12-05T20:38:02Z

@nodejs/nodejs-website PTAL

apps/site/types/supporters.ts

apps/site/next-data/generators/supportersData.mjs

apps/site/next-data/generators/vulnerabilities.mjs

apps/site/next-data/generators/supportersData.mjs

avivkeller · 2025-12-07T20:51:12Z

Fetch is still timing out occasionally :-/

https://vercel.com/openjs/nodejs-org/EeD4bMYCN1DPW8Zj3BEaNmq3wv1N

araujogui · 2025-12-07T20:52:14Z

apps/site/util/fetch.ts

+        throw e;
+      }
+
+      await setTimeout(delay);


Maybe we can add a backoff

A retry with backoff pattern

ovflowd · 2025-12-10T18:02:12Z

apps/site/next-data/generators/supportersData.mjs

-
-export default fetchOpenCollectiveData;
+export default () =>
+  fetchWithRetry(OPENCOLLECTIVE_MEMBERS_URL)


Can we please please revert the change from async functions to Promises. THANK YOU

ovflowd

Please revert unrelated changes 🙇

ovflowd · 2025-12-17T13:59:57Z

Bump @avivkeller

avivkeller · 2025-12-18T02:24:34Z

Sorry for the delay! This must've slipped in between the cracks. I'll get this up to speed tomorrow!

apps/site/util/fetch.ts

ovflowd

SGTM! Good stuff!

apps/site/util/fetch.ts

araujogui · 2025-12-18T17:46:03Z

apps/site/next-data/generators/vulnerabilities.mjs

 */
 export default async function generateVulnerabilityData() {
-  const response = await fetch(VULNERABILITIES_URL);
+  const response = await fetchWithRetry(VULNERABILITIES_URL);


Let's check if the response status is ok (200) before parsing the body. Otherwise, throw error too.

fix(fetch): fixup generators and add error handling

6a3b0bb

Copilot AI review requested due to automatic review settings December 4, 2025 23:29

avivkeller requested a review from a team as a code owner December 4, 2025 23:29

vercel bot deployed to Preview December 4, 2025 23:29 View deployment

Copilot started reviewing on behalf of avivkeller December 4, 2025 23:29 View session

Copilot finished reviewing on behalf of avivkeller December 4, 2025 23:32

Copilot AI reviewed Dec 4, 2025

View reviewed changes

apps/site/next-data/generators/vulnerabilities.mjs Outdated Show resolved Hide resolved

apps/site/next-data/generators/vulnerabilities.mjs Outdated Show resolved Hide resolved

apps/site/next-data/generators/supportersData.mjs Outdated Show resolved Hide resolved

araujogui requested changes Dec 6, 2025

View reviewed changes

apps/site/types/supporters.ts Outdated Show resolved Hide resolved

apps/site/next-data/generators/supportersData.mjs Outdated Show resolved Hide resolved

apps/site/next-data/generators/vulnerabilities.mjs Outdated Show resolved Hide resolved

ovflowd reviewed Dec 6, 2025

View reviewed changes

apps/site/next-data/generators/supportersData.mjs Outdated Show resolved Hide resolved

fixup!

d265052

avivkeller requested review from araujogui and ovflowd December 7, 2025 20:45

vercel bot deployed to Preview December 7, 2025 20:47 View deployment

fixup!

23ef046

vercel bot deployed to Preview December 7, 2025 20:50 View deployment

araujogui reviewed Dec 7, 2025

View reviewed changes

ovflowd reviewed Dec 10, 2025

View reviewed changes

ovflowd requested changes Dec 10, 2025

View reviewed changes

RatStar811 mentioned this pull request Dec 13, 2025

Please revert unrelated changes 🙇 actions/starter-workflows#3129

Open

fixup!

a7d80d1

avivkeller requested review from araujogui and ovflowd December 18, 2025 13:58

vercel bot deployed to Preview December 18, 2025 13:59 View deployment

ovflowd reviewed Dec 18, 2025

View reviewed changes

apps/site/util/fetch.ts Outdated Show resolved Hide resolved

ovflowd approved these changes Dec 18, 2025

View reviewed changes

ovflowd reviewed Dec 18, 2025

View reviewed changes

apps/site/util/fetch.ts Outdated Show resolved Hide resolved

fixup!

b680586

vercel bot deployed to Preview December 18, 2025 14:12 View deployment

araujogui requested changes Dec 18, 2025

View reviewed changes

Uh oh!

fix(fetch): fixup generators and add error handling #8395

Are you sure you want to change the base?

fix(fetch): fixup generators and add error handling #8395

Conversation

avivkeller commented Dec 4, 2025

Uh oh!

vercel bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 4, 2025

👋 Codeowner Review Request

Uh oh!

codecov bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Build Size Comparison

Summary

Changes

Uh oh!

avivkeller commented Dec 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avivkeller commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

araujogui Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

avivkeller Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

araujogui Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ovflowd Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

ovflowd commented Dec 17, 2025

Uh oh!

avivkeller commented Dec 18, 2025

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

araujogui Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Dec 4, 2025 •

edited

Loading

codecov bot commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 4, 2025 •

edited

Loading

avivkeller commented Dec 7, 2025 •

edited

Loading

araujogui Dec 8, 2025 •

edited

Loading