Skip to content

Conversation

@dcolley
Copy link

@dcolley dcolley commented Mar 4, 2025

What does it do?

Adds a new boot node to the chain-spec

What important points should reviewers know?

This has been tested internally:

./bin/moonbeam --tmp --chain ./chain-spec/moonbeam.json --bootnodes "/dns/boot.metaspan.io/tcp/51143/p2p/12D3KooWQNKbTaWXMAFV24Ytgjy93ZXLVSM3sJSbf8LNKqu3yrUM" --no-hardware-benchmarks --relay-chain-rpc-urls=ws://192.168.10.16:9944
# OK
./bin/moonbeam --tmp --chain ./chain-spec/moonbeam.json --bootnodes "/dns/boot.metaspan.io/tcp/51146/wss/p2p/12D3KooWQNKbTaWXMAFV24Ytgjy93ZXLVSM3sJSbf8LNKqu3yrUM" --no-hardware-benchmarks --relay-chain-rpc-urls=ws://192.168.10.16:9944
# OK

Is there something left for follow-up PRs?

no

What alternative implementations were considered?

n/a

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

no

What value does it bring to the blockchain users?

enhanced decentralisation

@RomarQ RomarQ requested a review from a team March 4, 2025 16:35
@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants