Skip to content

fix: plain replies deletion and edits #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lorenzo132 wants to merge 7 commits into
base: development
Choose a base branch
from
Open

fix: plain replies deletion and edits #3416

lorenzo132 wants to merge 7 commits into from
+116 −101

Conversation

@lorenzo132
Copy link
Member

@lorenzo132 lorenzo132 commented Dec 13, 2025

No description provided.

@lorenzo132 lorenzo132 mentioned this pull request Dec 13, 2025
Closed
StephenDaDev
StephenDaDev requested changes Dec 13, 2025
View reviewed changes
Copy link
Member

@StephenDaDev StephenDaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using color to check message status causes issue of mod_color is changed. A fix is being worked on.

@lorenzo132
fix: not rely on mod_color as originally was made.
e620a03 
This will avoid crashes when the mod_color get changed.
@lorenzo132
Copy link
Member Author

lorenzo132 commented Dec 13, 2025

Dont touch this yet. Working on resolving some issues.

martinbndr
martinbndr previously approved these changes Dec 13, 2025
View reviewed changes
@martinbndr martinbndr self-requested a review December 13, 2025 22:17
@martinbndr
Copy link
Contributor

martinbndr commented Dec 13, 2025

Dont touch this yet. Working on resolving some issues.

Nvm just saw it yet. I have re requested for my review to remove my approval

martinbndr
martinbndr previously approved these changes Dec 13, 2025
View reviewed changes
StephenDaDev
StephenDaDev previously approved these changes Dec 14, 2025
View reviewed changes
Copy link
Member

@StephenDaDev StephenDaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be solved.

@StephenDaDev StephenDaDev added the changelog Changes in PR have been added to draft release that will be used for the changelog on the next ver. label Dec 18, 2025
sebkuip
sebkuip requested changes Dec 18, 2025
View reviewed changes
Copy link
Member

@sebkuip sebkuip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image Image

Currently when deleting a message that is a note through discord's built in delete function, it causes an error. I'm unsure if this is something existing on main branch as well, but as this PR addresses deleting its best if this is fixed as well.

@lorenzo132 lorenzo132 dismissed stale reviews from StephenDaDev and martinbndr via 2758afe December 18, 2025 19:00
sebkuip
sebkuip approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@sebkuip sebkuip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this throughoutly now without any errors appearing on my side anymore. Issue above seems to be resolved.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephenDaDev StephenDaDev StephenDaDev approved these changes

@sebkuip sebkuip sebkuip approved these changes

@Taaku18 Taaku18 Awaiting requested review from Taaku18

@martinbndr martinbndr Awaiting requested review from martinbndr

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

changelog Changes in PR have been added to draft release that will be used for the changelog on the next ver.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lorenzo132 @martinbndr @StephenDaDev @sebkuip