-
Notifications
You must be signed in to change notification settings - Fork 163
fix options #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix options #901
Conversation
BigBlueHat
commented
Dec 16, 2025
- Fix base URL; simplify UX.
- Improve Safe Mode error display.
Deploying json-ld-org with
|
| Latest commit: |
3750831
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0aa4e3ed.json-ld-org.pages.dev |
| Branch Preview URL: | https://fix-options.json-ld-org.pages.dev |
08733cb to
a091164
Compare
|
Fixes several more items from #896 |
TallTed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, fwiw
|
|
Clicking more, I see safe mode maybe only works on the compact tab? But not elsewhere? In particular, not at all on the canonized tab. |
a091164 to
3750831
Compare
Hey, sorry. I was too narrowly focusing my changes... I've fixed that and Speaking of which...is there a reason the developer / code has to force safe mode on for |
I guess there is some risk here if the defaults change since they're being "matched" in the UX code rather than just not passing them in. Would calling out which one is the default help? Also, are these defaults unique to I have a longer term goal (now) to incorporate other libraries (Sophia via SoWASM and ldtr at least). I want to be sure what the UX's defaults are clear...more than I care what the underlying libraries defaults are...if that makes sense. |
I'm confused by the words there. To be clear, the way the playground safe mode feature was designed to work was that it was off by default for the regular API calls, because that's not part of the spec, and the theory was the UI should match that behavior. It was on by default for the canonize call, because that's how it was decided jsonld.js would work. The UI option to force safe mode on or off would override those default behaviors. I've always thought the UI was confusing, but the playground code was too hard to work on to fix it. Perhaps there should be a UI indicator to show the current mode depending on the algorithm and options currently selected. I did hope some of the playground updates could mostly match previous behavior as a first update step. Then work on these sorts of design decisions next. |