Skip to content

Bidi - Page.ExposeFunctionAsyncSupport #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kblok wants to merge 11 commits into
base: v21
Choose a base branch
from
Open

Bidi - Page.ExposeFunctionAsyncSupport #3041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8502036
Bidi - Page.ExposeFunctionAsyncSupport
kblok Dec 12, 2025
6e756ed
bump webdriver
kblok Dec 14, 2025
a3b3a09
Merge branch 'v21' into bidi-expose-function
kblok Dec 14, 2025
bd7049f
bump other libraries
kblok Dec 14, 2025
82163d4
Bring latest firefox
kblok Dec 14, 2025
21a7d44
use a working firefox version
kblok Dec 14, 2025
a59cd02
race check
kblok Dec 15, 2025
d13609a
prevent collection modification
kblok Dec 15, 2025
7d80129
let's see if this fixes that
kblok Dec 16, 2025
58191b6
more fixes coming from the update
kblok Dec 16, 2025
f1dbe6e
some ugly fixes
kblok Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,10 @@ You can switch between CDP and Bidi by changing the PuppeteerTestAttribute.IsCdp
You can switch between Chrome and Firefox by changing the PuppeteerTestAttribute.IsChrome property.
If you are fixing one single test, then you must run the entire test suite to confirm that you didn't break other tests.

### Verification Before Completion

**CRITICAL: Never claim a task is complete without verifying the build succeeds.** Always run `dotnet build PuppeteerSharp/PuppeteerSharp.csproj` before saying you are done. This project targets multiple frameworks (netstandard2.0 and net8.0), and code that compiles on one may fail on another. The test project only builds for net8.0, so passing test builds does NOT guarantee the main library builds correctly.

## Utilities and Helpers

### Helper Classes (`Helpers/`)
Expand Down
45 changes: 30 additions & 15 deletions lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,21 +768,6 @@
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[page.spec] *Page.exposeFunction*",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[page.spec] *Page.Events.DOMContentLoaded*",
Expand Down Expand Up @@ -1040,5 +1025,35 @@
"expectations": [
"FAIL"
]
},
{
"comment": "EvaluateFunctionOnNewDocumentAsync is not yet implemented for BiDi",
"testIdPattern": "[page.spec] Page Page.exposeFunction should be callable from-inside evaluateOnNewDocument",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"FAIL"
]
},
{
"comment": "Promise rejection timing issue in BiDi exposed function error handling",
"testIdPattern": "[page.spec] Page Page.exposeFunction should throw exception in page context",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"FAIL"
]
}
]
Loading
Loading