Skip to content

Conversation

@Neui
Copy link
Contributor

@Neui Neui commented May 14, 2021

Marking this as a draft since this is 'WIP'.

Primarily, it needs testing whenever it still works (and whenever catching the exception that way is correct). Ugh

Ready for review now. I believe this is the last instance the old dbus python package is being used, so I think we can remove that dependency after merging this PR.

@Neui Neui force-pushed the hamster-to-gio-dbus branch from c622a5d to 8a67286 Compare January 30, 2022 20:35
@Neui Neui marked this pull request as ready for review January 30, 2022 20:35
@Neui
Copy link
Contributor Author

Neui commented Jan 30, 2022

Ok I managed to get myself Hamster installed and tested (and fix) various functionalities I could find.

CC @flavin for review because you last updated the plugin (#465).

@Neui Neui changed the title Migrate hamster plugin to use dbus Migrate hamster plugin to use GIO dbus Jan 30, 2022
@Neui Neui force-pushed the hamster-to-gio-dbus branch from 8a67286 to da26160 Compare January 30, 2022 20:39
@diegogangl diegogangl added this to the 0.7 milestone Jan 30, 2022
Copy link
Contributor

@flavin flavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neui LGTM

@nekohayo
Copy link
Member

Hi @Neui, please rebase this for 0.7 :)

@nekohayo nekohayo marked this pull request as draft February 26, 2024 18:31
@nekohayo nekohayo added plugins Plugins and extra backends maintainability Automated tests suite, tooling, refactoring, or anything that makes it easier for developers labels Feb 26, 2024
@Neui Neui mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainability Automated tests suite, tooling, refactoring, or anything that makes it easier for developers plugins Plugins and extra backends

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants