-
Notifications
You must be signed in to change notification settings - Fork 179
Add conventional-comments package for espanso #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
smeech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A simple single trigger, making use of anchors and aliases.
No script/shell or potentially malicious code.
I've made a few "nitpick" comments beyond the "homepage:` requirement!
| description: A simple package to show how to create your own one! | ||
| version: 0.1.0 | ||
| author: Lucas Bonanni | ||
| tags: ["conventional comments", "github"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you kindly add a homepage: key and value, please? We've had difficulty merging some packages without it.
homepage: https://github.com/lucasbonanni/hub/tree/main would do, although you may have a broader homepage of your own.
| @@ -0,0 +1,30 @@ | |||
| # Conventional Comments Match Configuration | |||
| # Inspired by https://conventionalcomments.org/ | |||
| variables: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the docs, would you name this section anchors:, please?
|
|
||
| matches: | ||
| - trigger: ":ccc" | ||
| form: '[[label]] ([[decorations]]): ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of decorations for both a variable and an anchor/alias name is a little confusing. labels/label is marginally better.
Would you mind using, for example, decorations_list and labels_list, for the anchors/aliases?
| decorations: | ||
| type: choice | ||
| values: *decorations | ||
| description: "Single line comment format // Comment" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this line for?
Inspired by the Conventional Comments project.