Skip to content

Conversation

@ad08fee3
Copy link
Contributor

I noticed the README for this package was incorrect. I'm fixing some inconsistencies.

(The package itself is also about three years out of date, so I'm thinking I'm going to fork it and post another update, so I'm considering this practice 🙂 )

@ad08fee3 ad08fee3 marked this pull request as ready for review November 25, 2025 06:20
@smeech
Copy link
Collaborator

smeech commented Dec 11, 2025

Inclusion of the update to emoji-picker has introduced a conflict which prevents merging of this PR - can you resolve it?

The other updates are "in-version". If I merge them, they'll be picked up by the hub repo, but probably won't appear in the package website. You may prefer to submit entirely new versions, including all three files for each.

@ad08fee3 ad08fee3 reopened this Dec 14, 2025
@ad08fee3
Copy link
Contributor Author

Forgive my churn on this pull request. My previous employer only used trunk-based development instead of Github and normal git-flow. So I'm a dev of 10+ years trying to learn the "proper" way to use git, ha.

@smeech
Copy link
Collaborator

smeech commented Dec 14, 2025

No problem! If you look at the other PRs there are some which have been pending for a long time. I rely on a GUI program for my own Git needs.

The way the Hub is set up to require new versions for major updates is unconventional.

I'll run the CI checks and merge unless I hear to the contrary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants