[test] Add @also_with_proxy_to_pthread decorator. NFC #25971
Merged
+33
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Dec 17, 2025
|
|
||
| @parameterized({ | ||
| '': ([],), | ||
| 'pthreads': (['-pthread', '-sPROXY_TO_PTHREAD', '-sEXIT_RUNTIME'],), |
Member
There was a problem hiding this comment.
This also added coverage for EXIT_RUNTIME?
Collaborator
Author
There was a problem hiding this comment.
I think this was added conservatively (since sometime we had issues with EXIT_RUNTIME being needed with PROXY_TO_PTHREAD. However, since removing it doesn't break the test I think its the right thing to do here.
sbc100
added a commit
that referenced
this pull request
Dec 17, 2025
- Cleanup implemenation of SDL_Delay - Add testing of SDL_Timer/SDL_Delay under SDL1 - Add testing of SDL_Timer/SDL_Delay when running on pthread - Rename test_sdl2_timer.c -> test_sdl_timer.c since it works with both SDL1 and SDL2 - Avoid taking the address of stack locals in test_sdl_timer.c. Depends on #25971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.