Skip to content

fix(discord.js): make FileUploadModalData.attachments optional #11364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
majiayu000 wants to merge 1 commit into from
+6 −1
Closed

fix(discord.js): make FileUploadModalData.attachments optional #11364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/discord.js/typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2562,7 +2562,7 @@ export interface SelectMenuModalData<Cached extends CacheType = CacheType> exten
}

export interface FileUploadModalData extends BaseModalData<ComponentType.FileUpload> {
attachments: ReadonlyCollection<Snowflake, Attachment>;
attachments?: ReadonlyCollection<Snowflake, Attachment>;
customId: string;
values: readonly Snowflake[];
}
Expand Down
5 changes: 5 additions & 0 deletions packages/discord.js/typings/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ import type {
FetchedThreadsMore,
FetchPinnedMessagesResponse,
FileComponentData,
FileUploadModalData,
ForumChannel,
Guild,
GuildApplicationCommandManager,
Expand Down Expand Up @@ -3044,3 +3045,7 @@ await textChannel.send({
],
flags: MessageFlags.IsVoiceMessage,
});

// FileUploadModalData.attachments should be optional (issue #11359)
declare const fileUploadModalData: FileUploadModalData;
expectType<ReadonlyCollection<Snowflake, Attachment> | undefined>(fileUploadModalData.attachments);