types(ModalSubmitInteraction): make attachments optional

[rahuld109]

Summary

Makes FileUploadModalData.attachments optional to match runtime behavior.

Problem

When a modal has an optional FileUpload component and the user doesn't upload a file, component.attachments is undefined at runtime. However, the TypeScript types marked it as required, causing no compile-time warning but runtime errors when accessing the property.

Solution

Add ? to the attachments field in FileUploadModalData interface:

// Before
attachments: ReadonlyCollection<Snowflake, Attachment>;

// After  
attachments?: ReadonlyCollection<Snowflake, Attachment>;

Closes #11359

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
discord-js	Skipped		Dec 14, 2025 4:23am
discord-js-guide	Skipped		Dec 14, 2025 4:23am

[coderabbitai]

📝 Walkthrough

Walkthrough

The attachments field in FileUploadModalData is made optional in the TypeScript type definitions to align with runtime behavior where the field may be undefined.

Changes

Cohort / File(s)	Summary
Type definition update packages/discord.js/typings/index.d.ts	Made attachments field optional in FileUploadModalData interface

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Single file change affecting one field declaration
• Straightforward type adjustment (required → optional) to reflect actual runtime behavior
• Minimal risk; verify that no code strictly depends on attachments being non-optional in consumers of FileUploadModalData

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: making attachments optional in the FileUploadModalData type for ModalSubmitInteraction.
Description check	✅ Passed	The description is directly related to the changeset, clearly explaining the problem, solution, and the specific type change being made.
Linked Issues check	✅ Passed	The PR successfully addresses issue #11359 by making the attachments field optional, matching the runtime behavior where attachments can be undefined.
Out of Scope Changes check	✅ Passed	All changes are in scope: only the attachments field in FileUploadModalData is modified to match the objective of issue #11359.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4fc79a and fe5f536.

📒 Files selected for processing (1)

• packages/discord.js/typings/index.d.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

packages/discord.js/typings/index.d.ts (1)

packages/collection/src/collection.ts (1)

• ReadonlyCollection (6-10)

🔇 Additional comments (1)

packages/discord.js/typings/index.d.ts (1)

2564-2568: Correct typing fix; note TS-breaking change for consumers
Making FileUploadModalData.attachments optional matches the observed runtime (undefined when no file is uploaded) and forces proper guards/optional chaining. Consider calling this out in release notes/changelog since it can break downstream TypeScript builds that assumed attachments was always present.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}