Skip to content

Conversation

@dsabsay
Copy link
Contributor

@dsabsay dsabsay commented Dec 20, 2025

What this PR does:
Uses new build-image with go 1.25.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the ci/cd label Dec 20, 2025
@dsabsay
Copy link
Contributor Author

dsabsay commented Dec 20, 2025

I'm attempting to fix this here: #7171

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 21, 2025
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 8b48921

@dsabsay
Copy link
Contributor Author

dsabsay commented Dec 22, 2025

The version of protoc changed, presumably via the underlying debian package repository:

libprotoc 3.12.4 -> libprotoc 3.21.12

cortex [0]$ docker run --rm -it --entrypoint sh quay.io/cortexproject/build-image:master-59491e9aae
# protoc --version
libprotoc 3.12.4
# exit
cortex [0]$ docker run --rm -it --entrypoint sh quay.io/cortexproject/build-image:master-8b48921f71
# protoc --version
libprotoc 3.21.12
# exit
cortex [0]$ 

In version v3.14.0, the protobuf compiler changed the go module references:

Update go_package options to reference google.golang.org/protobuf module.
https://github.com/protocolbuffers/protobuf/releases/tag/v3.14.0

The original module (github.com/golang/protobuf) mentions it is deprecated:

It has been superseded by the google.golang.org/protobuf module
source: https://github.com/golang/protobuf

I re-generated the protobuf code using the latest build image.

Signed-off-by: dsabsay <[email protected]>
@friedrichg
Copy link
Member

@dsabsay almost there. we need the vendor folder commited too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd lgtm This PR has been approved by a maintainer size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants