-
Notifications
You must be signed in to change notification settings - Fork 6
docs: weekly architecture docs refresh #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Update agent-server.mdx to reflect current server responsibilities and endpoints (source: openhands-agent-server/*) - Fix security.mdx source link; add ConfirmationPolicy reference; add Last updated and Source commit footer Co-authored-by: openhands <[email protected]>
…)\n\nCo-authored-by: openhands <[email protected]>
…thored-by: openhands <[email protected]>
xingyaoww
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird -- i don't think agent server package is included in docs.json?
…ples, inline source links\n\nCo-authored-by: openhands <[email protected]>
…inline source links\n\nCo-authored-by: openhands <[email protected]>
Place agent-server at the end of the SDK Components section for consistent ordering. Co-authored-by: openhands <[email protected]>
67909cf to
f0328fa
Compare
…'Agent Server', and simplify selected endpoints Also keeps concise Client SDK REST + WebSocket examples with inline GitHub source links. Co-authored-by: openhands <[email protected]>
Added! But now I'm not sure: did we leave it out intently, for a reason like, we recommend to use the remote workspace to handle communication? That doesn't apply to communication from other languages than python, so it seems like it can be useful. On a side note, the existing document contained a lot of hallucinations, a lot fixed. 😅 |
|
@OpenHands We have syntax errors in mintlify for the two initial diagrams, please fix. This is one, but look at the next one too:
|
|
I'm on it! enyst can track my progress at all-hands.dev |
…ards, avoid /* and braces in labels)
- Replace '/api/*' and '/sockets/*' with safe labels in diagrams
- Replace '{id}' with '<id>' in node label
Co-authored-by: openhands <[email protected]>
|
Summary of changes just made What I fixed
Why it was failing
Precise edits
Validation
Commit
Next steps
|
docs.json
Outdated
| "sdk/arch/condenser", | ||
| "sdk/arch/security" | ||
| "sdk/arch/security", | ||
| "sdk/arch/agent-server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we put it under the agent-server group and make this as a description for agent server?
https://docs.openhands.dev/sdk/guides/agent-server/overview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OpenHands lets do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on it! enyst can track my progress at all-hands.dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of changes just made
What you asked
- “Put it under the agent-server group and make this as a description for agent server”
What I changed
- Moved the Agent Server architecture page into the Remote Agent Server group in the SDK Guides navigation:
- Added: sdk/arch/agent-server under SDK > Guides > Remote Agent Server (immediately after overview)
- Removed: sdk/arch/agent-server from SDK > Architecture > SDK Components
Validation
- Confirmed docs.json parses (jq OK)
- Git diff shows only the intended navigation edits (3 insertions, 2 deletions)
Commit
- Branch: docs-weekly-arch-refresh
- Commit: docs(nav): move Agent Server architecture page under Remote Agent Server group
- Co-authored-by: openhands [email protected]
Checklist
- Request fully addressed: Agent Server page is now nested under the agent-server group
- No extraneous changes
- Pushed updates to the existing PR branch
If you want it ordered differently within the group (e.g., after “local-server”), tell me and I’ll adjust.
…ver group\n\n- Remove sdk/arch/agent-server from SDK Components\n- Add sdk/arch/agent-server under Guides > Remote Agent Server (after overview)\n\nCo-authored-by: openhands <[email protected]>
xingyaoww
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more i read into this doc, the more i feel it probably make sense to combine this docs with agent-server overview page we currently have, and have this doc link to specific docs of Docker/APIWorkspace when discussing about *Workspace that spawns agent server, wdyt?
Summary of updates
This weekly refresh updates the SDK architecture documentation under sdk/arch based on the latest HEAD of OpenHands/software-agent-sdk (commit 93d405c9).
Updated pages
Citations (inline in the docs)
Source of truth
Process notes
@enyst can click here to continue refining the PR