refactor: simplify background handling #38913
Merged
+7
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3ps
added
team-core-extension-ux
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +7 -27)
|
n3ps
commented
Dec 16, 2025
ui/css/base-styles.scss
Outdated
| } | ||
| } | ||
| html[data-theme] { | ||
| background-color: var(--color-background-default); |
Contributor
Author
There was a problem hiding this comment.
Matches main container
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Builds ready [d4c9476]
UI Startup Metrics (1259 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [0fffcae]
UI Startup Metrics (1243 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
AndyMBridges
approved these changes
Dec 17, 2025
NidhiKJha
approved these changes
Dec 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Builds ready [1b1ef1c]
UI Startup Metrics (1271 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [de2fc83]
UI Startup Metrics (1247 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-13.14.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify handling of dark/light theme background using the light-dark function
Also fixes #38827 where the document needs to match the main container background
Changelog
CHANGELOG entry: null
Related issues
Fixes: #38827
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Simplifies global dark/light theming by using CSS light-dark and consolidating document/background color handling in
ui/css/base-styles.scss.ui/css/base-styles.scss):color-scheme: dark lightandlight-dark(...)in:rootto set default text and background colors.prefers-color-schemeand non-data-themeconditionals with a singlehtml[data-theme]rule for theme overrides.#app-contentso the document and main container backgrounds align.Written by Cursor Bugbot for commit de2fc83. This will update automatically on new commits. Configure here.