release(runway): cherry-pick fix: cp-13.13.0 not execute QuotedSwapTransactionData if quoted swap is not selected #38817
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansactionData if quoted swap is not selected (#38812) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Fix error from QuotedSwapTransactionData when swap is rendered. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: #38811 ## **Manual testing steps** 1. Submit uniswap transaction 2. Open advance view 3. No error should be thrown ## **Screenshots/Recordings** TODO ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Render `QuotedSwapTransactionData` only when `isQuotedSwapDisplayedInInfo` from dapp-swap context is true, preventing errors when a quoted swap isn't selected. > > - **Confirmations UI** > - Use `useDappSwapContext` to access `isQuotedSwapDisplayedInInfo` in `AdvancedDetails`. > - Conditionally render `QuotedSwapTransactionData` based on this flag instead of always rendering it. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 14ea8b1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +3 -1)
|
Collaborator
Builds ready [2dc0087]
UI Startup Metrics (1284 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
HowardBraham
approved these changes
Dec 12, 2025
metamaskbot
added
the
release-13.13.0
Collaborator
|
No release label on PR. Adding release label release-13.13.0 on PR, as PR was cherry-picked in branch 13.13.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix error from QuotedSwapTransactionData when swap is rendered.
Changelog
CHANGELOG entry:
Related issues
Fixes: #38811
Manual testing steps
Screenshots/Recordings
TODO
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Render
QuotedSwapTransactionDataonly whenisQuotedSwapDisplayedInInfois true to avoid errors when no quoted swap is selected.ui/pages/confirmations/.../advanced-details/advanced-details.tsx:useDappSwapContextto readisQuotedSwapDisplayedInInfo.QuotedSwapTransactionDatainstead of always rendering it.NonceDetails,TransactionData, orNestedTransactionData.Written by Cursor Bugbot for commit 2dc0087. This will update automatically on new commits. Configure here.
6f7421c