Add Samples Check to azpysdk
#44417
Merged
Add Samples Check to azpysdk
#44417
+356
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds samples check functionality to the azpysdk tool, enabling developers to run package samples locally using azpysdk samples . instead of relying solely on the tox-based framework. This change supports the ongoing migration from tox to azpysdk as mentioned in the tool usage guide.
Key changes:
- Implementation of a new
samplescheck class with sample execution logic - Registration of the samples command in the main CLI
- Updated documentation to reflect the new azpysdk samples command
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/tools/azure-sdk-tools/azpysdk/samples.py | New file implementing the samples check with timeout handling, ignored samples configuration, and sample execution logic |
| eng/tools/azure-sdk-tools/azpysdk/main.py | Imports and registers the new samples check |
| doc/tool_usage_guide.md | Adds samples command to the tool usage documentation |
| doc/dev/sample_guide.md | Updates sample testing documentation to mention azpysdk as an alternative to tox |
Co-authored-by: Copilot <[email protected]>
scbedd
reviewed
Dec 17, 2025
scbedd
reviewed
Dec 17, 2025
scbedd
reviewed
Dec 17, 2025
scbedd
requested changes
Dec 17, 2025
Member
scbedd
left a comment
scbedd
left a comment
There was a problem hiding this comment.
Thanks for tackling this! I have some comments that need addressing before I sign off on this one!
scbedd
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42601
tox version installs subprocess32 but i didn't include that 🤔
next: delete
original test_run_samples.py