Return empty page if block inscription page request is out of range (#4439)

Author: casey

src/subcommand/server.rs

@@ -1936,19 +1936,16 @@ impl Server {
     AcceptJson(accept_json): AcceptJson,
   ) -> ServerResult {
     task::block_in_place(|| {
-      let page_size = 100;
-
-      let page_index_usize = usize::try_from(page_index).unwrap_or(usize::MAX);
-      let page_size_usize = usize::try_from(page_size).unwrap_or(usize::MAX);
+      const PAGE_SIZE: usize = 100;
 
       let mut inscriptions = index
         .get_inscriptions_in_block(block_height)?
         .into_iter()
-        .skip(page_index_usize.saturating_mul(page_size_usize))
-        .take(page_size_usize.saturating_add(1))
+        .skip(page_index.into_usize().saturating_mul(PAGE_SIZE))
+        .take(PAGE_SIZE.saturating_add(1))
         .collect::<Vec<InscriptionId>>();
 
-      let more = inscriptions.len() > page_size_usize;
+      let more = inscriptions.len() > PAGE_SIZE;
 
       if more {
         inscriptions.pop();
@@ -1968,7 +1965,7 @@ impl Server {
           inscriptions,
           more,
           page_index,
-        )?
+        )
         .page(server_config)
         .into_response()
       })
@@ -6982,6 +6979,12 @@ next
       StatusCode::OK,
       r".*<a href=/inscription/[[:xdigit:]]{64}i0>.*</a>.*",
     );
+
+    server.assert_response_regex(
+      "/inscriptions/block/102/2",
+      StatusCode::OK,
+      r".*<div class=thumbnails>\s*</div>.*",
+    );
   }
 
   #[test]

src/templates/inscriptions_block.rs

@@ -17,12 +17,8 @@ impl InscriptionsBlockHtml {
     inscriptions: Vec<InscriptionId>,
     more_inscriptions: bool,
     page_index: u32,
-  ) -> Result<Self> {
-    if page_index != 0 && inscriptions.is_empty() {
-      return Err(anyhow!("page index {page_index} exceeds inscription count"));
-    }
-
-    Ok(Self {
+  ) -> Self {
+    Self {
       block,
       inscriptions,
       prev_block: block.checked_sub(1),
@@ -37,7 +33,7 @@ impl InscriptionsBlockHtml {
       } else {
         None
       },
-    })
+    }
   }
 }