Use cmake directly

Author: kraenhansen

CMakeLists.txt

@@ -1,14 +1,29 @@
 cmake_minimum_required(VERSION 3.15...3.31)
 project(node-api-cts)
 
+set(NODE_API_HEADERS_DIR ${PROJECT_SOURCE_DIR}/node_modules/node-api-headers)
+
+if(NOT EXISTS ${NODE_API_HEADERS_DIR})
+  message(FATAL_ERROR "Expected ${NODE_API_HEADERS_DIR} to exist")
+endif()
+
+if(MSVC)
+  set(NODE_API_LIB ${PROJECT_BINARY_DIR}/node.lib)
+  set(NODE_API_DEF ${NODE_API_HEADERS_DIR}/def/node_api.def)
+  execute_process(COMMAND ${CMAKE_AR} /def:${NODE_API_DEF} /out:${NODE_API_LIB} ${CMAKE_STATIC_LINKER_FLAGS})
+  set(NODE_API_SRC ${PROJECT_SOURCE_DIR}/implementors/node/win_delay_load_hook.cc)
+endif()
+
 function(add_node_api_cts_addon ADDON_NAME SRC)
-  add_library(${ADDON_NAME} SHARED ${SRC} ${CMAKE_JS_SRC})
+  add_library(${ADDON_NAME} SHARED ${SRC} ${NODE_API_SRC})
   set_target_properties(${ADDON_NAME} PROPERTIES PREFIX "" SUFFIX ".node")
-  target_include_directories(${ADDON_NAME} PRIVATE ${CMAKE_JS_INC})
-  target_link_libraries(${ADDON_NAME} PRIVATE ${CMAKE_JS_LIB})
+  target_include_directories(${ADDON_NAME} PRIVATE ${NODE_API_HEADERS_DIR}/include)
+  target_link_libraries(${ADDON_NAME} PRIVATE ${NODE_API_LIB})
   target_compile_features(${ADDON_NAME} PRIVATE cxx_std_17)
   target_compile_definitions(${ADDON_NAME} PRIVATE ADDON_NAME=${ADDON_NAME})
   set_target_properties(${ADDON_NAME} PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}")
+  # TODO: Set these conditionally?
+  set_target_properties(${ADDON_NAME} PROPERTIES LINK_FLAGS "-undefined dynamic_lookup")
 endfunction()
 
 file(GLOB_RECURSE cmake_dirs RELATIVE ${CMAKE_SOURCE_DIR} tests/*/CMakeLists.txt)
@@ -17,8 +32,3 @@ foreach(cmake_file ${cmake_dirs})
   get_filename_component(subdir ${cmake_file} DIRECTORY)
   add_subdirectory(${subdir})
 endforeach()
-
-if(MSVC AND CMAKE_JS_NODELIB_DEF AND CMAKE_JS_NODELIB_TARGET)
-  # Generate node.lib
-  execute_process(COMMAND ${CMAKE_AR} /def:${CMAKE_JS_NODELIB_DEF} /out:${CMAKE_JS_NODELIB_TARGET} ${CMAKE_STATIC_LINKER_FLAGS})
-endif()

implementors/node/win_delay_load_hook.cc

@@ -0,0 +1,44 @@
+// This file is copied from
+// https://github.com/nodejs/node-gyp/blob/db5385c5467e5bfb914b9954f0313c46f1f4e10d/src/win_delay_load_hook.cc
+
+/*
+ * When this file is linked to a DLL, it sets up a delay-load hook that
+ * intervenes when the DLL is trying to load the host executable
+ * dynamically. Instead of trying to locate the .exe file it'll just
+ * return a handle to the process image.
+ *
+ * This allows compiled addons to work when the host executable is renamed.
+ */
+
+#ifdef _MSC_VER
+
+#pragma managed(push, off)
+
+#ifndef WIN32_LEAN_AND_MEAN
+#define WIN32_LEAN_AND_MEAN
+#endif
+
+#include <windows.h>
+
+#include <delayimp.h>
+#include <string.h>
+
+static FARPROC WINAPI load_exe_hook(unsigned int event, DelayLoadInfo* info) {
+  HMODULE m;
+  if (event != dliNotePreLoadLibrary)
+    return NULL;
+
+  if (_stricmp(info->szDll, HOST_BINARY) != 0)
+    return NULL;
+
+  // try for libnode.dll to compat node.js that using 'vcbuild.bat dll'
+  m = GetModuleHandle(TEXT("libnode.dll"));
+  if (m == NULL) m = GetModuleHandle(NULL);
+  return (FARPROC) m;
+}
+
+decltype(__pfnDliNotifyHook2) __pfnDliNotifyHook2 = load_exe_hook;
+
+#pragma managed(pop)
+
+#endif

package-lock.json

@@ -6,12 +6,14 @@
   "scripts": {
     "node:test": "node --test ./implementors/node/run-tests.ts",
     "lint": "eslint",
-    "build-addons": "cmake-js build"
+    "addons:configure": "cmake -G Ninja -S . -B ./build",
+    "addons:build": "cmake --build ./build",
+    "addons:clean": "git clean -xf '**/*.node' && rm -rf ./build"
   },
   "devDependencies": {
     "@types/node": "^24.10.1",
-    "cmake-js": "^7.4.0",
-    "eslint": "^9.39.1"
+    "eslint": "^9.39.1",
+    "node-api-headers": "^1.7.0"
   },
   "dependencies": {
     "amaro": "^1.1.5"