Refact parser logic to use OFX 1.0.2 for version 103 files

Author: marcosdemelo

Gemfile.lock

@@ -1,15 +1,17 @@
 PATH
   remote: .
   specs:
-    ofx (0.3.6)
+    ofx (0.3.7)
       nokogiri (>= 1.13.1, < 1.16.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
     byebug (11.1.3)
     diff-lcs (1.5.1)
-    nokogiri (1.15.7-x86_64-darwin)
+    mini_portile2 (2.8.9)
+    nokogiri (1.15.7)
+      mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
     racc (1.8.1)
     rake (13.0.6)

lib/ofx.rb

@@ -9,7 +9,6 @@
 require 'ofx/errors'
 require 'ofx/parser'
 require 'ofx/parser/ofx102'
-require 'ofx/parser/ofx103'
 require 'ofx/parser/ofx211'
 require 'ofx/foundation'
 require 'ofx/balance'

lib/ofx/parser.rb

@@ -17,10 +17,8 @@ def initialize(resource)
         end
 
         case headers["VERSION"]
-        when /100|102/ then
+        when /100|102|103/ then
           @parser = OFX102.new(:headers => headers, :body => body)
-        when /103/ then
-          @parser = OFX103.new(:headers => headers, :body => body)
         when /200|202|211|220/ then
           @parser = OFX211.new(:headers => headers, :body => body)
         else

lib/ofx/parser/ofx103.rb

@@ -2,7 +2,7 @@ module OFX
   module Version
     MAJOR = 0
     MINOR = 3
-    PATCH = 6
+    PATCH = 7
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

lib/ofx/version.rb

@@ -1,6 +1,17 @@
 require "spec_helper"
 
 describe OFX::Parser do
+  def ofx_example_to(version)
+    <<~OFX_CONTENT
+      <?xml version="1.0" encoding="US-ASCII"?>
+
+      <?OFX OFXHEADER="200" VERSION="#{version}" SECURITY="NONE" OLDFILEUID="NONE" NEWFILEUID="NONE"?>"
+
+      <OFX>
+      </OFX>
+    OFX_CONTENT
+  end
+
   before do
     @ofx = OFX::Parser::Base.new("spec/fixtures/sample.ofx")
   end
@@ -47,30 +58,50 @@
     }.should raise_error(OFX::UnsupportedFileError)
   end
 
-  it "uses 102 parser to parse version 100 ofx files" do
+  it "should use 102 parser to parse version 100 ofx files" do
+    expect(OFX::Parser::OFX102).to receive(:new).and_return('ofx-102-parser')
+
+    ofx = OFX::Parser::Base.new(ofx_example_to('100'))
+    expect(ofx.parser).to eql 'ofx-102-parser'
+  end
+
+  it "should use 102 parser to parse version 102 ofx files" do
+    expect(OFX::Parser::OFX102).to receive(:new).and_return('ofx-102-parser')
+
+    ofx = OFX::Parser::Base.new(ofx_example_to('102'))
+    expect(ofx.parser).to eql 'ofx-102-parser'
+  end
+
+  it "should use 102 parser to parse version 103 ofx files" do
     expect(OFX::Parser::OFX102).to receive(:new).and_return('ofx-102-parser')
 
-    ofx = OFX::Parser::Base.new(ofx_2_example('100'))
+    ofx = OFX::Parser::Base.new(ofx_example_to('103'))
     expect(ofx.parser).to eql 'ofx-102-parser'
   end
 
-  it "uses 211 parser to parse version 200 ofx files" do
+  it "should use 211 parser to parse version 200 ofx files" do
     expect(OFX::Parser::OFX211).to receive(:new).and_return('ofx-211-parser')
 
-    ofx = OFX::Parser::Base.new(ofx_2_example('200'))
+    ofx = OFX::Parser::Base.new(ofx_example_to('200'))
     ofx.parser.should == 'ofx-211-parser'
   end
 
   it "should use 211 parser to parse version 202 ofx files" do
     OFX::Parser::OFX211.stub(:new).and_return('ofx-211-parser')
-    ofx = OFX::Parser::Base.new(ofx_2_example('202'))
+    ofx = OFX::Parser::Base.new(ofx_example_to('202'))
+    ofx.parser.should == 'ofx-211-parser'
+  end
+
+  it "should use 211 parser to parse version 211 ofx files" do
+    OFX::Parser::OFX211.stub(:new).and_return('ofx-211-parser')
+    ofx = OFX::Parser::Base.new(ofx_example_to('211'))
     ofx.parser.should == 'ofx-211-parser'
   end
 
-  it "uses 211 parser to parse version 220 ofx files" do
+  it "should use 211 parser to parse version 220 ofx files" do
     expect(OFX::Parser::OFX211).to receive(:new).and_return('ofx-211-parser')
 
-    ofx = OFX::Parser::Base.new(ofx_2_example('220'))
+    ofx = OFX::Parser::Base.new(ofx_example_to('220'))
     expect(ofx.parser).to eql 'ofx-211-parser'
   end
 
@@ -124,13 +155,4 @@
       @ofx.headers.size.should be(9)
     end
   end
-
-  def ofx_2_example(version)
-    <<-EndOfx
-<?xml version="1.0" encoding="US-ASCII"?>
-<?OFX OFXHEADER="200" VERSION="#{version}" SECURITY="NONE" OLDFILEUID="NONE" NEWFILEUID="NONE"?>"
-<OFX>
-</OFX>
-    EndOfx
-  end
 end