Merge pull request #313 from MITLibraries/use-251-no-eyebrows-for-some-tabs

Only show the eyebrow in multi-source tabs

Author: JPrevost

app/helpers/record_helper.rb

@@ -186,6 +186,12 @@ def location(loc)
     "<strong>#{loc[:name]}</strong> #{loc[:collection]} (#{loc[:call_number]})"
   end
 
+  # Returns true if the active tab includes multiple sources.
+  # As our tabs adjust over time, we will need to revisit this logic.
+  def multi_source_tab?
+    %w[all primo timdex website].include?(@active_tab)
+  end
+
   private
 
   def render_kind_value(list)

app/views/search/_result.html.erb

@@ -1,6 +1,8 @@
 <li class="result use">
   <div class="result-content">
-    <p class="eyebrow"><%= result[:eyebrow] %></p>
+    <% if multi_source_tab? && result[:eyebrow].present? %>
+      <p class="eyebrow"><%= result[:eyebrow] %></p>
+    <% end %>
     <h3 class="record-title">
       <span class="sr">Title: </span>
       <%= link_to_result(result) %>

app/views/search/_result_primo.html.erb

@@ -1,6 +1,8 @@
 <li class="result primo">
   <div class="result-content">
-    <p class="eyebrow"><%= result[:eyebrow] %></p>
+    <% if multi_source_tab? && result[:eyebrow].present? %>
+      <p class="eyebrow"><%= result[:eyebrow] %></p>
+    <% end %>
     <h3 class="record-title">
       <span class="sr">Title: </span>
       <% if result[:links]&.find { |link| link['kind'] == 'full record' } %>

test/helpers/record_helper_test.rb

@@ -387,4 +387,18 @@ class RecordHelperTest < ActionView::TestCase
     expected = "<i class='fa-sharp fa-solid fa-question' aria-hidden='true''></i>"
     assert_equal expected, icon('question')
   end
+
+  test 'multi_source_tab? returns true for tabs that combine sources' do
+    %w[all primo timdex website].each do |tab|
+      @active_tab = tab
+      assert multi_source_tab?
+    end
+  end
+
+  test 'multi_source_tab? returns false for other tabs' do
+    %w[alma cdi aspace timdex_alma fake_tab].each do |tab|
+      @active_tab = tab
+      assert_not multi_source_tab?
+    end
+  end
 end