Skip to content

Commit e9abd1b

Browse files
committed
Updates date range joiner
Why are these changes being introduced: * Some date ranges ended up looking like `1999-01-01-1999-01-02` with the current previous logic which is confusing. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-296 How does this address that need: * Changes our joiner from `-` to ` to ` for date ranges.
1 parent c5db4e3 commit e9abd1b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/models/normalize_timdex_record.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ def date_range
182182
# first.
183183
relevant_date = relevant_dates.first
184184

185-
"#{relevant_date['range']['gte']}-#{relevant_date['range']['lte']}"
185+
"#{relevant_date['range']['gte']} to #{relevant_date['range']['lte']}"
186186
end
187187

188188
def contributors

test/models/normalize_timdex_record_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def minimal_record
8282
{ 'kind' => 'creation', 'range' => { 'lte' => '2023', 'gte' => '2020' } }
8383
]
8484
normalized = NormalizeTimdexRecord.new(record, 'test').normalize
85-
assert_equal '2020-2023', normalized[:date_range]
85+
assert_equal '2020 to 2023', normalized[:date_range]
8686
end
8787

8888
test 'normalizes format from content type' do

0 commit comments

Comments
 (0)