Merge pull request #324 from MITLibraries/use-298-limit-citation-to-cdi

Skip citation for Alma records

Author: JPrevost

app/models/normalize_primo_record.rb

@@ -115,6 +115,9 @@ def links
   end
 
   def citation
+    # We don't want to include citations for Alma records at this time. If we include them in the future they need
+    # to be cleaned up as they currently look like `Engineering village 2$$QEngineering village 2`
+    return if alma_record?
     return unless @record['pnx']['display']
 
     @record['pnx']['display']['ispartof']&.first

test/models/normalize_primo_record_test.rb

@@ -81,11 +81,19 @@ def cdi_record
     assert_empty normalized[:links]
   end
 
-  test 'normalizes citation' do
-    normalized = NormalizePrimoRecord.new(full_record, 'test').normalize
+  test 'normalizes citation for cdi records' do
+    record = full_record.dup
+    record['pnx']['control']['recordid'] = ['cdi_crossref_primary_10_1234_test_article']
+
+    normalized = NormalizePrimoRecord.new(record, 'test').normalize
     assert_equal 'Journal of Testing, Vol. 2, Issue 3', normalized[:citation]
   end
 
+  test 'skips citation for alma records' do
+    normalized = NormalizePrimoRecord.new(full_record, 'test').normalize
+    assert_nil normalized[:citation]
+  end
+
   test 'handles missing citation' do
     normalized = NormalizePrimoRecord.new(minimal_record, 'test').normalize
     assert_nil normalized[:citation]